Do not generate new address when a new payment is detected #4984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukks
reviewed
May 18, 2023
Kukks
approved these changes
May 18, 2023
Co-authored-by: Andrew Camilleri <evilkukka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bitcoin address is used for a payment, it was being switched with a new address.
We got feedback of customers and merchants very confused about it, and thinking they got scammed.
I believe we should just reuse addresses. This isn't good for privacy, but this is a corner case that almost never happen. It isn't really worth bothering support with this.
Fix #4980