Various plugin fixes #5577
Merged
Various plugin fixes #5577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will: * Clear any previous pending actions of a plugin if you click uninstall * Show the plugin version that was disabled * Show an update button on disabled plugins instead of install * if a plugin is scheduled to be installed/updated, it will show which version was scheduled to be updated. If a newer version if available than the scheduled one, it will show an option to switch to that
Kukks
force-pushed
the
offer-update-on-disabled
branch
from
a786cff
to
d3063ec
Compare
Kukks
changed the title
|
Note: While we should get this out in the next release, I need to redo how we build this plugin page as it's been constantly added on as complex version features were added to plugins. cc @pavlenex |
Kukks
commented
Jan 16, 2024
| @@ -108,6 +108,7 @@ public async Task UploadPlugin(IFormFile plugin) | |||
| public void UninstallPlugin(string plugin) | |||
| { | |||
| var dest = _dataDirectories.Value.PluginDir; | |||
| PluginManager.CancelCommands(dest, plugin); | |||
There was a problem hiding this comment.
This is actually a bugfix where you could end up in a situation of scheduling installs/updates and then scheduling a delete, causing the UI to look unintuitive on what's going to happen until they execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will: