Refactor Wallet import code #5638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kukks
force-pushed
the
passportimport
branch
8 times, most recently
from
81a5b0a
to
8193358
Compare
|
We actually have support MetacoSA/NBitcoin#1141 Will try with this, can probably simplify a bit. |
NicolasDorier
force-pushed
the
passportimport
branch
from
f1f1c82
to
4718c4e
Compare
The code for wallet import was incredibly messy as it evolved over time from various requests. This PR: * splits up each supported format into its own file * Supports taproot descriptors (through a hack until NBitcoin supports it internally) fixes btcpayserver#5518 * Reduces different paths for handling electrum/non-electrum xpubs * Allows plugins to add their own import support formats for onchain wallets.
NicolasDorier
force-pushed
the
passportimport
branch
3 times, most recently
from
36d71ca
to
49937ee
Compare
NicolasDorier
force-pushed
the
passportimport
branch
from
49937ee
to
c750ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for wallet import was incredibly messy as it evolved over time from various requests.
This PR: