New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor fee provider #5643
Refactor fee provider #5643
Conversation
29538d4
to
b705ba3
Compare
9ba5905
to
49972df
Compare
I will remove the refactor you did to focus on the bug fix. The refactor still hardcode the mempool fee provider, but on top of this limit fee providers to depends solely on bootstrap services. We should probably do something later, but for now let's just focus on fixing the bug. On top of this, fee provider itself might require a refactoring sooner or later, as I don't think it should depends on BTCPayNetwork, probably should depends only to a cryptoCode, but still need to think about it.
Your PR is also doing some linear interpolation stuff you didn't really explained why. Looking into it. |
d903f16
to
327f404
Compare
The fee provider ended up glued with a hardcoded factory. This PR: * removes this glue and uses the DI to register fee provider for a network. (allows plugins to add their own fee providers, for any network * Add a 10 second timeout to mempoolspace fee fetching as they are slow at times
c8e6f48
to
cf0bbb3
Compare
cf0bbb3
to
3197e6a
Compare
I will do a followup PR so that, like the rates, the fees are fetched in the background, avoiding a checkout page load hanging |
The fee provider ended up glued with a hardcoded factory. This PR:
Fixes [Bug]: Gateway Timeout (504) on Invoice Creation because Mempool.space is down #5641.