Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checkout page load time by fetching recommended fee in the background periodically #5672

Merged
merged 1 commit into from Jan 18, 2024
Merged

Improve checkout page load time by fetching recommended fee in the background periodically #5672

merged 1 commit into from Jan 18, 2024

Conversation

NicolasDorier
Copy link
Member

A failure to fetch rates on mempool.space shouldn't result in slow display of the checkout page.

  • Removed timeout for querying mempool.space
  • Refresh the fee rate periodically every 3 minutes
  • If fee of mempool aren't in the cache when requesting it, fallback directly to NBX
  • Bump cache expiration to 25min

@NicolasDorier NicolasDorier force-pushed the backgroundfetchrate branch 2 times, most recently from 23d6e0f to 7b1c4c9 Compare January 18, 2024 07:39
@NicolasDorier NicolasDorier merged commit d6806dc into btcpayserver:master Jan 18, 2024
4 checks passed
@NicolasDorier NicolasDorier deleted the backgroundfetchrate branch January 18, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@NicolasDorier