update csv export to include full date and time in 12 hour format

[TChukwuleta]

Resolves #5915

[Kukks]

This is a breaking change so extra care should be considered. Maybe we need to see what the old export on the invoices page used to export first

[TChukwuleta]

This is the csv export view prior to this requested change. In 24 hours format:

[dennisreimann]

To not break the curent format I'd suggest to simply use proper ISO format with added timezone info, like this:

Suggested change

	modifyFields(srv.result.fields, data, 'datetime', v => v ? moment(v).format("dddd, MMMM Do YYYY, h:mm:ss a"): v);
	modifyFields(srv.result.fields, data, 'datetime', v => v ? (new Date(v)).toISOString().replace('T', ' '));

Not sure if v is a Date already, if so it could be v.toISOString().

[NicolasDorier]

we shouldn't do string manipulations to format dates when we have a library to do things properly.

[NicolasDorier]

@TChukwuleta I think you only have to change 'YYYY-MM-DD hh:mm:ss' to 'YYYY-MM-DD HH:mm:ss'. This format is making sure excel recognize the cells as date.

[TChukwuleta]

Yea. done that @NicolasDorier. Excel export now in 24 hour format

Thanks