Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcclient: custom http client for http post mode #1547

Open
therealssj opened this issue Mar 9, 2020 · 2 comments
Open

rpcclient: custom http client for http post mode #1547

therealssj opened this issue Mar 9, 2020 · 2 comments

Comments

@therealssj
Copy link

Problem

The rpcclient only allows you configure the http client but there is no way to set my own http client so if I want to define my own custom transport its not possible.

Solution
simple function to set the httpClient directly

httpClient *http.Client

I would be happy to do a PR if this suggestion is approved

@jakesylvestre
Copy link
Collaborator

@therealssj please take a stab at the PR. Can't wait to see what you come up with!

@jcvernaleo
Copy link
Member

As a general rule, we don't 'approve' suggestions. We can certainly discuss suggestions, but ultimately, we either approve or deny PRs. Obviously there are some suggestions that are far enough off from what we want that we can say we are very unlikely to accept a PR for it, but generally, it is code we evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants