Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE and Swap.signa: - needs to be added as a valid character #226

Open
Valareos opened this issue May 3, 2022 · 8 comments
Open

HIVE and Swap.signa: - needs to be added as a valid character #226

Valareos opened this issue May 3, 2022 · 8 comments

Comments

@Valareos
Copy link
Contributor

Valareos commented May 3, 2022

  • is a valid character for HIVE ENGINE addresses.
@rogerwim
Copy link

rogerwim commented May 3, 2022

Can you provide a source for this?

@Valareos
Copy link
Contributor Author

Valareos commented May 3, 2022

image

@Valareos
Copy link
Contributor Author

Valareos commented May 3, 2022

I got accounts on hive engine with - in them :P hive-146999 actually is the signum community group on HIVE

@rogerwim
Copy link

rogerwim commented May 3, 2022

Yes, I meant are there any official pages on what characters are allowed rather then just trial and error

@Valareos
Copy link
Contributor Author

Valareos commented May 3, 2022

I will look

@Valareos
Copy link
Contributor Author

Valareos commented May 3, 2022

https://peakd.com/hive-174578/@starstrings01/hive-account-creation-1-or-or-hive-basics

TLDR:

Your username cannot be less than 3 characters.
Your username cannot contain more than 16 characters.
Characters allowed includes alphabet, numbers and hyphen (-).
Your username should start with a small letter.
Your username can only begin with a letter and end with either a letter or a number.

@Valareos
Copy link
Contributor Author

Valareos commented May 3, 2022

The pull request will do a base fix of the issue, Im not 100% experienced with REGEX so no idea how to get it to match full requirement

@Valareos
Copy link
Contributor Author

Valareos commented May 3, 2022

ok, updated the pull request with a more robust regex that meets the hive engine username requirements. I did a test build, it works.. but contracts created with the new version (allowing the -) doesnt show up on older versions of btdex. I suspect this is intended behavior to ensure it only reads what it thinks is valid contracts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants