-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE and Swap.signa: - needs to be added as a valid character #226
Comments
Can you provide a source for this? |
I got accounts on hive engine with - in them :P hive-146999 actually is the signum community group on HIVE |
Yes, I meant are there any official pages on what characters are allowed rather then just trial and error |
I will look |
https://peakd.com/hive-174578/@starstrings01/hive-account-creation-1-or-or-hive-basics TLDR: Your username cannot be less than 3 characters. |
The pull request will do a base fix of the issue, Im not 100% experienced with REGEX so no idea how to get it to match full requirement |
ok, updated the pull request with a more robust regex that meets the hive engine username requirements. I did a test build, it works.. but contracts created with the new version (allowing the -) doesnt show up on older versions of btdex. I suspect this is intended behavior to ensure it only reads what it thinks is valid contracts |
The text was updated successfully, but these errors were encountered: