Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hermes command line arguments are incorrect #125

Open
gibson042 opened this issue Oct 15, 2022 · 0 comments · May be fixed by #138
Open

hermes command line arguments are incorrect #125

gibson042 opened this issue Oct 15, 2022 · 0 comments · May be fixed by #138

Comments

@gibson042
Copy link
Contributor

eshost/lib/agents/hermes.js

Line 35 in d180999

this.args.unshift('-Xintl', '-enable-eval', '-fenable-tdz');
uses -fenable-tdz, which was renamed to -Xenable-tdz as of hermes v0.10.0: facebook/hermes@f811a0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the correct CLI option to enable TDZ in Hermes gibson042/eshost
1 participant
@gibson042