Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event parameter missing from calculator exercise #14

Closed
skorasaurus opened this issue Jul 27, 2018 · 1 comment
Closed

event parameter missing from calculator exercise #14

skorasaurus opened this issue Jul 27, 2018 · 1 comment

Comments

@skorasaurus
Copy link
Contributor

The calculator exercise does not function properly (input values are not accepted) when using Firefox because of a missing parameter at line 90 in calculator.js

Without the event parameter, the calculator works as expected in chrome which is an odd behavior that Brian even mentions. At 9:25 of https://frontendmasters.com/courses/web-development-v2/javascript-html-and-css-solution-part-2 that it's not optional. ;)

PR forthcoming.
@skorasaurus skorasaurus mentioned this issue Jul 27, 2018
Merged
@1Marc
Copy link
Collaborator

1Marc commented Jul 28, 2018

Looks good, thanks! Accepted.

@1Marc 1Marc closed this as completed Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@1Marc @skorasaurus