Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String representation of an expression shows incorrectly #21

Closed
Pikachu920 opened this issue Jan 5, 2018 · 1 comment
Closed

String representation of an expression shows incorrectly #21

Pikachu920 opened this issue Jan 5, 2018 · 1 comment
Assignees

Comments

@Pikachu920
Copy link

Issue:
String representation of an expression shows incorrectly


Versions:

  • Skript 2.2-dev25
  • PaperSpigot 8b18730
  • Minecraft 1.8.8
  • skript-mirror 0.8.3

Script:

get expression not multiple:
  continue

command error:
  trigger:
    loop not multiple:

Output:

[20:59:39 INFO]: [Skript] Reloading tests.sk...
[20:59:41 ERROR]: Can't loop com.btk5h.skriptmirror.skript.custom.CustomExpression$ExpressionHandler@ff4b47e because it's only a single value (tests.sk, line 71: loop not multiple:')
[20:59:41 INFO]: [Skript] Encountered 1 error while reloading tests.sk!
@btk5h btk5h added the type: bug label Jan 5, 2018
@btk5h btk5h self-assigned this Jan 5, 2018
@btk5h
Copy link
Owner

btk5h commented Jan 5, 2018

Interesting. Skript uses both Object#toString() and Debuggable#toString(Event, boolean). Skript's SimpleExpression helper class automatically overrides toString() to return toString(null, false), which is why most other expressions work completely fine.

I have a few other classes that extend Expression instead of SimpleExpression, so it looks like I'll need to update those as well.

@btk5h btk5h closed this as completed in a74e8c1 Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants