Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018-19 rookies not in players.json file #62

Closed
jamesclarence opened this issue Nov 3, 2018 · 2 comments
Closed

2018-19 rookies not in players.json file #62

jamesclarence opened this issue Nov 3, 2018 · 2 comments

Comments

@jamesclarence
Copy link

Hi! I was using the findPlayer function to find a couple of rookies (Trae Young, Luka Doncic), and I saw that rookie players this season (2018-19) aren't in the players.json file. Thanks

@bttmly
Copy link
Owner

bttmly commented Nov 5, 2018

Hey! Thanks for the heads up – I'll publish a new version soon, but FYI you can always update this at runtime nba.updatePlayers() will update the nba.players object. Packaging a JSON file is just for convenience – using nba.updatePlayers() will always be a better option if you want the most up-to-date rosters since they change constantly.

If you have a long-running application you might want to call nba.updatePlayers() every so often to ensure your data is fresh. Otherwise if you're writing a script for data scraping or similar, you can just call that first then do whatever else you need.

@jamesclarence
Copy link
Author

Thanks, using nba.updatePlayers() worked for me

@bttmly bttmly closed this as completed Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants