Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webp anim 7TV Emotes aren't animated #183

Closed
StephanBruh opened this issue Jul 1, 2021 · 10 comments · Fixed by #190
Closed

webp anim 7TV Emotes aren't animated #183

StephanBruh opened this issue Jul 1, 2021 · 10 comments · Fixed by #190
Labels
bug Something isn't working confirmed

Comments

@StephanBruh
Copy link
Contributor

Bug Report

Current Behavior
Emotes on 7TV that should be animated are just static

Expected behavior/code
7TV Emotes are animated

Environment

  • bttv-android version: v0.8.2
  • Android version: 10
  • Device: OnePlus 6T
@welcome
Copy link

welcome bot commented Jul 1, 2021

Thank you for opening this issue ♥️ A maintainer should be by to give feedback soon.
peepoArrive

@FoseFx
Copy link
Member

FoseFx commented Jul 2, 2021

Can't confirm. Are there certain emotes that don't work for you?

@StephanBruh
Copy link
Contributor Author

StephanBruh commented Jul 2, 2021

Can't confirm. Are there certain emotes that don't work for you?

Oh yeah, looks like its only happening to certian wide animated emotes, some examples;
https://7tv.app/emotes/60ae6b4486fc40d488d0b324
https://7tv.app/emotes/60b1868058275001781a8bd5
https://7tv.app/emotes/60b2cd2aab2a2a9c958b2695
https://7tv.app/emotes/60ae47919986a00349442244

But some do work for me like;
https://7tv.app/emotes/6043a11f1d4963000d9dae4c
https://7tv.app/emotes/6063d9f8f4dc10001426b946

chatterino:
ezgif com-gif-maker (3)

app:
ezgif com-gif-maker (4)

@FoseFx FoseFx added bug Something isn't working confirmed and removed unconfirmed labels Jul 2, 2021
@FoseFx FoseFx added this to In progress in Issue Queue Jul 2, 2021
@FoseFx
Copy link
Member

FoseFx commented Jul 2, 2021

The reason is probably, that e.g. AlienGathering has the mime type image/webp not image/gif and bttv-android/Glide can not determine whether it should be animated.

@FoseFx
Copy link
Member

FoseFx commented Jul 2, 2021

This is a known issue in Glide, litte I can do about it bumptech/glide#571 :/

@FoseFx FoseFx removed this from In progress in Issue Queue Jul 2, 2021
@StephanBruh
Copy link
Contributor Author

Damn thats a old issue, maybe your able to count the frames and change the mime?

@FoseFx
Copy link
Member

FoseFx commented Jul 2, 2021

I'll have a look at https://github.com/zjupure/GlideWebpDecoder and see if I can add it somehow

@FoseFx FoseFx added this to To do in Issue Queue Jul 2, 2021
@FoseFx FoseFx changed the title 7TV Emotes aren't animated webp anim 7TV Emotes aren't animated Jul 2, 2021
@FoseFx FoseFx moved this from To do to In progress in Issue Queue Jul 5, 2021
@FoseFx FoseFx mentioned this issue Jul 5, 2021
6 tasks
Issue Queue automation moved this from In progress to Done Jul 11, 2021
@StephanBruh
Copy link
Contributor Author

Reopening issue because emotes with webp are still not animated.

emote example;
https://7tv.app/emotes/60b529e7c871a89f1541972e
https://7tv.app/emotes/60845b712a652395a02c56ef

@FoseFx
Copy link
Member

FoseFx commented Aug 28, 2021

I'm working on the v11.4.0 rebase right now and there it seems to work. Idk what fixed it but I'll take it.
So this will be fixed in v0.11.0-beta.

Please note that webp animations are static in the EmotePicker right now (see #199)

@StephanBruh
Copy link
Contributor Author

Alright thanks! Yeah I know they are static in the emote picker. Will wait for the beta then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants