Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious replacement characters (U+FFFD) in events #38

Closed
Count-Count opened this issue Dec 15, 2019 · 3 comments
Closed

Spurious replacement characters (U+FFFD) in events #38

Count-Count opened this issue Dec 15, 2019 · 3 comments

Comments

@Count-Count
Copy link
Contributor

The unicode decoder state is not saved across SSEClient.next() calls. Thus if the buffer ends in the middle of a multi-byte encoding the decoder fails to decode the char on the next call.
@btubbs btubbs closed this as completed in c85c6f2 Feb 27, 2020
@TheSandDoctor
Copy link
Collaborator

TheSandDoctor commented Feb 27, 2020 •
edited

Thanks so much for fixing, @Count-Count , and for merging, @btubbs ! :)

@dvorapa
Copy link

dvorapa commented Feb 28, 2020 •
edited

Per https://phabricator.wikimedia.org/T181443 the issue might be still there :/

@TheSandDoctor
Copy link
Collaborator

TheSandDoctor commented Feb 28, 2020 •
edited

Can confirm. Experienced post-merge (by me, installing from master directly) @btubbs @Count-Count . Probably want to re-open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dvorapa @TheSandDoctor @Count-Count