New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve input validation #182
Comments
May I give it a try? |
@mskuybeda Sure |
A small question though, what do you want to validate in Zoom level? And what inputs need to be validated other than preview? |
@mskuybeda Right now you can't remove all numbers while typing so its annoying ( there is always a number displayed cant be an empty string ) and is hard to use. Also we should check for min and max values, currenty the min value in zoom is a dynamic value generated inside the render component, and the max value is "100%", |
Check the |
So for zoom, do you want to make a minimum as low as 0% for all images? Or enable user to change it to any value? |
No the min zoom value is calculated on the render component |
Ok. Still not really sure what do you want to change to a current state. Right now as I understand it calculates min zoom value depending on the image. Different images have different min value. What would you like to change about it? Secondly, I have almost finished preview. Would you like it to appear empty on load or to still have now erasable 0 |
Empty is fine, thanks ✌️ |
Created a pull request for preview line. |
All text inputs were removed on v2.0.0, so this issue is not longer relevant |
The current inputs on the toolbar component requires some improvements:
The text was updated successfully, but these errors were encountered: