Add versioned API #128
Open
Add versioned API #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btzy
force-pushed
the
versioned-api
branch
3 times, most recently
from
199cf42
to
409c8b6
Compare
btzy
force-pushed
the
versioned-api
branch
6 times, most recently
from
c32851d
to
2b7fc83
Compare
btzy
force-pushed
the
versioned-api
branch
2 times, most recently
from
d0ab030
to
2d30563
Compare
btzy
force-pushed
the
versioned-api
branch
2 times, most recently
from
4e0db56
to
821d325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API function for each of the four kinds of dialogs, which take in a versioned struct. The version is set by an inline function in nfd.h, and the library checks the version to determine the number of fields in the struct. Additional fields can then be added to the end of the struct without breaking forward compatibility (binary built with an older version of NFDe works with a newer version of NFDe) or backward compatibility (automatically by ignoring the additional fields).
This will allow new options to be added without breaking forward compatibility, which will make #90, #93, #99, and #126 implementable.
TODO: SetFolder on Windows, take args struct by reference in nfd.h.
Resolves #92.