Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid output for async arrow function (expression) #109

Closed
adrianheine opened this issue Feb 12, 2018 · 5 comments · May be fixed by #125
Closed

Invalid output for async arrow function (expression) #109

adrianheine opened this issue Feb 12, 2018 · 5 comments · May be fixed by #125
Labels

Comments

@adrianheine
Copy link
Member

async (a) => {}

is transpiled to

!functionasync (a) {}

However,

const x = async (a) => {}

is also wrong:

var x = function async (a) {}
@shirotech
Copy link
Contributor

This happens because async is not supported? Please see #125 I have made a pull request to support this based on #12

@adrianheine
Copy link
Member Author

No, that's not true. bublé cannot transpile async, but it should already be able to correctly pass it through.

@shirotech
Copy link
Contributor

Okay I get what you’re saying. In this case, can you please give examples of expected output? Would buble transpile partially leaving async intact syntactically? Or whenever there’s async code it would completely ignore it?

@aleclarson
Copy link
Contributor

@Van-Nguyen It should transpile the arrow function, yet preserve the async keyword.

@adrianheine
Copy link
Member Author

adrianheine commented Mar 1, 2019

Related: async a => {} makes bublé hang. Edit: That's #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants