Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary and octal number literals are not transpiled if base prefix is uppercase #74

Closed
adrianheine opened this issue Dec 10, 2017 · 1 comment · Fixed by #128
Closed

Binary and octal number literals are not transpiled if base prefix is uppercase #74

adrianheine opened this issue Dec 10, 2017 · 1 comment · Fixed by #128
Labels
bug good first issue

Comments

@adrianheine
Copy link
Member

Both 0B and `0O' are valid base prefixes. Example:

0B01100 === 0O14
@danielcaldas danielcaldas mentioned this issue Apr 23, 2018
Merged
@danielcaldas
Copy link
Contributor

Hey there @adrianheine, this PR should make buble compliant with the base prefixes #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix binary octal num literals danielcaldas/buble
2 participants
@adrianheine @danielcaldas