Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser test is interfering with import of the library in a regular interpreter #95

Closed
Bubobubobubobubo opened this issue Nov 7, 2022 · 3 comments
Closed

Parser test is interfering with import of the library in a regular interpreter #95

Bubobubobubobubo opened this issue Nov 7, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Bubobubobubobubo
Copy link
Owner

Expected behavior: running python3 -m asyncio followed by from sardine import * must import Sardine and show the boot screen. Problem: in the current version, it does not import Sardine at all. The fix is surely to trigger the initialisation code based on context. I'll see what I can do about it.
@Bubobubobubobubo Bubobubobubobubo added the bug Something isn't working label Nov 7, 2022
@Bubobubobubobubo
Copy link
Owner Author

Fixed by dd6bb7c?

@mugulmd
Copy link
Contributor

mugulmd commented Nov 7, 2022

Tell me if I'm wrong, but another solution to make this work (simpler/cleaner in my opinion) would be to just create the environment variable before running python3 -m asyncio with export SARDINE_INIT_SESSION=YES, right ?

@Bubobubobubobubo
Copy link
Owner Author

No worries, there is a fix for it now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bubobubobubobubo @mugulmd