Fix segfault during st destroy #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 9, 2020
- EAPI7 - Unconditionally remove t/00_signature.t - Ensure CFLAGS passed to make/compiler - Resurrect compie-testing for Bundle::DBD::Pg - Disable t/03*.t and t/04*.t due to https://rt.cpan.org/Ticket/Display.html?id=132965 Upstream: - Prevent double-free memory errors https://rt.cpan.org/Ticket/Display.html?id=130681 - Fix crash when pg_error_field is called https://rt.cpan.org/Ticket/Display.html?id=130721 - Update list of Postgres reserved words in quote.c - Fix tests for 32-bit machines - Eagerly NULL-ify PQclear-ed things to remove race conditions https://rt.cpan.org/Ticket/Display.html?id=131522 - Allow localtime from Time::Piece, and other magical arrays, to be used directly as a bind value again. - Fix tests for EnterpriseDB server - Add small warning regarding ShowErrorStatement - Indicate non-key index columns in statistics_info - Return empty result set instead of undef from statistics_info when table NOTEXIST and not $unique_only - Fix Segfault during st destroy bucardo/dbdpg#57 bucardo/dbdpg#66 - Improve testing for table_info() - Fix failing 'fulltest' target on BSD - Return table info row last in statistics_info for compat with pre-8.3 servers - Fix ASC_OR_DESC field in statistics_info - Indicate NULL ordering in statistics_info - Remove test that assumed '(12,34)' to be invalid for type 'circle' as Postgres now handles it better. - Prevent DBI turning AutoCommit 'on' after a failed commit - Fix memory leak in dbdimp.c by redoing the "last_result" internals https://rt.cpan.org/Ticket/Display.html?id=132812 - Fix regression in Perl length() for returned query results - Make $sth->finish() do less, so that among other things, pg_error_field still works on the last action performed. Package-Manager: Portage-2.3.100, Repoman-2.3.22 Signed-off-by: Kent Fredric <kentnl@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #57
As mentioned in that issue, the underlying cause is #52. I am not sure that this is the right fix, but the issue seems to be the fact that the
imp_dbhis left with an invaliddo_tmp_sthafter an earlierdocall, whichpg_st_FETCH_attribtries to use. The design ofdo_tmp_sthseems prone to this sort of issue.