Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message when not logged in #51

Merged
merged 1 commit into from
Jan 22, 2018
Merged

fix: error message when not logged in #51

merged 1 commit into from
Jan 22, 2018

Conversation

helio-frota
Copy link
Member

before:

2017-12-27T14:58:51.344Z INFO loading configuration
2017-12-27T14:58:51.370Z INFO using namespace myproject at https://192.168.42.194:8443
2017-12-27T14:58:51.378Z INFO creating archive of e2e, src, .angular-cli.json, package.json
2017-12-27T14:58:51.423Z ERROR 
2017-12-27T14:58:51.423Z ERROR Status code undefined

after:

2018-01-18T20:57:05.842Z INFO loading configuration
2018-01-18T20:57:05.866Z INFO using namespace myproject at https://192.168.42.194:8443
2018-01-18T20:57:05.871Z INFO creating archive of package.json, model, server.js
2018-01-18T20:57:05.908Z ERROR Unauthorized
2018-01-18T20:57:05.908Z ERROR Status code 401

Connects to nodeshift/nodeshift#162

@ghost ghost assigned helio-frota Jan 18, 2018
@ghost ghost added the in progress label Jan 18, 2018
@coveralls
Copy link

coveralls commented Jan 18, 2018

Coverage Status

Coverage decreased (-1.5%) to 93.617% when pulling 1e1b32b on helio-frota:pr into caf5e08 on bucharest-gold:master.

@lholmquist
Copy link
Member

I think this is probably ok,

I'm pretty sure i've seen this before, but i can't reproduce. I did a oc logout first, then ran the npm run openshift and i get this:

2018-01-22T15:12:28.106Z INFO loading configuration
2018-01-22T15:12:28.145Z INFO using namespace node-rest-http at https://api.starter-ca-central-1.openshift.com:443
2018-01-22T15:12:28.166Z INFO creating archive of package.json, app.js, public, bin, LICENSE
2018-01-22T15:12:28.378Z ERROR buildconfigs "nodejs-rest-http-s2i" is forbidden: User "system:anonymous" cannot get buildconfigs in the namespace "node-rest-http": User "system:anonymous" cannot get buildconfigs in project "node-rest-http"
2018-01-22T15:12:28.378Z ERROR Status code 403

Does this happen after a clean install from minishift?

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @helio-frota I think you actually implemented what I intended to when I wrote buildError(). Thanks! 👍

I've seen this before when I have minishift running, but haven't logged in.

@helio-frota
Copy link
Member Author

@lholmquist

Does this happen after a clean install from minishift?

At least here. Yes

@lholmquist
Copy link
Member

@helio-frota if you want to squash those commits we can merge this in 👍

@lholmquist lholmquist merged commit 329d226 into nodeshift:master Jan 22, 2018
@ghost ghost removed the in progress label Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants