New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Negative Tax and Fee (Credits) #3450
Comments
Negative taxes or fees must always be entered as positive. (Unsigned) to be closed |
@Nirus2000 there is still miscommunication here, it needs more discussion.
There are lots of things I don't understand:
|
Yes we know... use the PP-Forum and not here.
Because this was determined programmatically and also by the developer.
A bank is a credit institution that provides banking and other financial services to its banking customers.
Account statements, settlements, securities transactions, custody account movements.... This is the wrong place for this kind of basic question and is better off in the PP forum. There is no error here. TO BE CLOSED |
Checks in the program can easily be changed. This is a call for @buchen. The discussion moved to https://forum.portfolio-performance.info/t/dividends-with-imputation-credits/17148/6 |
@flywire to be closed. |
Work around at https://forum.portfolio-performance.info/t/dividends-with-imputation-credits/17148/15 involving a manual file edit. |
I now see this happening with fees. Wouldn't have opinion re: taxes, but getting a fee rebate is absolutely normal practice, and should be recorded as such. @flywire, can you please update the title to mention fees too? And what's worrying is that during import, invalid data gets recorded at all, due to this line: portfolio/name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/ExtractorUtils.java Line 225 in b1b4c48
Math.abs() , because all usage places would need to be checked for correct usage of sign (negated in many places, etc.). So, in my fork I added convertToSignedNumberLong() and use it in places which I can verify to have the right effect.
Fixing bug with transaction edit dialog not allowing signed numbers is easier:
|
Describe the bug
PP Gui does not allow negative tax (tax credit) input but it works if data file is edited directly.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Allow tax credits which are part of income, eg
Screenshots
Desktop (please complete the following information):
Version: 0.64.4 (July 2023)
Platform: win32, x86_64
The text was updated successfully, but these errors were encountered: