Rebuild Commerzbank PDF-Importer #2145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alle *.txt-TestFiles gelöscht, weil diese durch den neuen PR umbenannt wurden.
Issue https://forum.portfolio-performance.info/t/pdf-import-von-commerzbank/9865/6 Issue https://forum.portfolio-performance.info/t/pdf-import-von-commerzbank/9865/7 Delete all *.txt TestFiles because they were renamed with this PR Rebuild complete PDF-Importer Modify PDFExtractorUtils.java to support fee with exchangeRate
…rzbank/9865/6 Issue https://forum.portfolio-performance.info/t/pdf-import-von-commerzbank/9865/7 Delete all *.txt TestFiles because they were renamed with this PR Rebuild complete PDF-Importer Modify PDFExtractorUtils.java to support fee with exchangeRate Add Note in Dividende and optimize some regEx
Issue https://forum.portfolio-performance.info/t/pdf-import-von-commerzbank/9865/6 Issue https://forum.portfolio-performance.info/t/pdf-import-von-commerzbank/9865/7 Delete all *.txt TestFiles because they were renamed with this PR Rebuild complete PDF-Importer Modify PDFExtractorUtils.java to support fee with exchangeRate Add Note in Dividende and optimize some regEx
Nirus2000
changed the title
|
Rebased and merged with c680aee Danke 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://forum.portfolio-performance.info/t/pdf-import-von-commerzbank/9865/6
Issue https://forum.portfolio-performance.info/t/pdf-import-von-commerzbank/9865/7
Delete all *.txt TestFiles because they were renamed with this PR
Rebuild complete PDF-Importer
Modify PDFExtractorUtils.java to support fee with exchangeRate
Hallo @buchen
der Importer war einfach so nicht mehr zu gebrauchen und musste vollständig neu erstellt werden.
Die Commerzbank stellt immer zwei Dokumente zu Verfügung, egal welche Transaktion abgerechnet wird. Einmal
den Kauf/Verkauf/Dividenden und als zweites die Steuerliche Behandlung der Transaktion.
Diese müssen im Importer auch getrennt voneinander behandelt werden, welche er jetzt tut.
Es waren einfach zu viele Fehler im alten Importer drin. Die IBAN als ISIN verwendet, keine Steuer oder Gebührenverarbeitungen Steuerbehandlungen wurden als Dividenden gebucht, die TestCases waren teilweise falsch etc. etc. und im allgemeinen war einfach alles doppelt drin, was im gesamten dann einfach keinen Sinn ergab.
Den einzigen Teil den ich nicht angefasst habe, ist die Giro-Transaktion, da hier nur ein Dokumente zur Verfügung stand und dieses vor kurzem implementiert wurde.
Des Weiteren habe ich die PDFExtractorUtils.java erweitert für Gebühren mit Wechselkursen.
Grüße und bleib Gesund
Alex