Rebuild OnVista PDF-Importer #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge buy and sell transaction Merge delivery_inbound and delivery_outbound transaction Fix missing time in dateTime Fix dateTime with year of two and four digits Fix incorrect extraction of the name from the security Fix calculation of withholding taxes Fix of incorrect regEx for shares and bonds Fix some other wrong transactions Deleting duplicate testcases and testfiles Delete addDepositTransaction() https://forum.portfolio-performance.info/t/pdf-import-von-onvista-bank/2076/83 Integration in the PDFExtractorUtils.java (fee's and tax's) Information: Deletion of the "deposit statement" (Depotauszug) function. This results in the recorded transactions all being posted to the date the deposit statement was created. e.g. (deposit statement as at 31.12.2010). So if PDF's are imported where individual transactions such as purchase, sale (...) are recorded, double bookings will occur. This PDF is not suitable for the use of PP and leads to false entries in total.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge buy and sell transaction
Merge delivery_inbound and delivery_outbound transaction
Fix missing time in dateTime
Fix dateTime with year of two and four digits
Fix incorrect extraction of the name from the security
Fix calculation of withholding taxes
Fix of incorrect regEx for shares and bonds
Fix some other wrong transactions
Deleting duplicate testcases and testfiles
Delete addDepositTransaction()
https://forum.portfolio-performance.info/t/pdf-import-von-onvista-bank/2076/83
Integration in the PDFExtractorUtils.java (fee's and tax's)
Information:
Deletion of the "deposit statement" (Depotauszug) function.
This results in the recorded transactions all being posted to the date the deposit statement was created. e.g. (deposit statement as at 31.12.2010). So if PDF's are imported where individual transactions such as purchase, sale (...) are recorded, double bookings will occur.
This PDF is not suitable for the use of PP and leads to false entries in total.
For an example look in Depotauszug