Modify ebase PDF-Importer to support new fee format #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://forum.portfolio-performance.info/t/pdf-import-fuer-ebase/7204/57 Add more tests Fix fee transaction for Depotführungsentgelt
Nirus2000
deleted the
Modify-ebase-PDF-Importer-to-support-new-fee-format
branch
|
Genial. Wollt mich gerade dransetzen. Dein Vorschlag im Pull Request hat jedoch meine PDF gefressen. Dankeschön |
|
@christen90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.portfolio-performance.info/t/pdf-import-fuer-ebase/7204/57
Fix fee transaction for Depotführungsentgelt
Add more tests to check if the PDF importer works correctly
Hallo @buchen
bei ebase werden die Depotführungsgebühren mit einem Verkauf von Anteilen
abgegolten. (siehe hier) Hier ergab sich folgendes Problem, das z.B. der PDF-Debug "Umsatzabrechnung12.txt"
unvollständig war, da hier der Verkauf der Anteile fehlten. Ergo hatte das zufolge, dass es dazu kam,
dass eventuell doppelt die Gebühren gebucht wurden.
Mit dem ersetzten PDF-Debug aus dem Forum (siehe oben), sieht man, wie die Buchungen korrekt laufen bei Ebase.
Daher habe ich den PDF-Debug "Umsatzabrechnung12.txt" gegen den PDF-Debug aus dem Forum ersetzt und die
fehlerhaften Buchungen entfernt. DIes betraf lediglich "Umsatzabrechnung14.txt".
Gruß Alex