Fixes serialization error after duplicate dashboard column #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem. I ran into a similar problem. We really have to be careful about the "toList" usage. Wherever we know that the immutable list will not do it, we could add |
|
Or we add a |
buchen
added a commit
that referenced
this pull request
Feb 25, 2023
It's useful in cases where we need to modify the resulting list, which is not possible with the immutable list returned by the Stream#toList method. We use this method to differentiate between cases where a mutable list is necessary and to prevent the IDE from suggesting the use of Stream#toList. Issue: #3197
OnkelDok
deleted the
fix_serialization_error_when_duplicate_dashboard_column
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forum.portfolio-performance.info/t/nach-duplizieren-einer-spalte-im-dashboard-kann-xml-nicht-mehr-geparst-werden/23294
Sorry for including the error with #3175. I blindly followed the code change suggestion from eclipse. The
.toList()creates an immutable list which leads to serialization problem.