Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update redis default settings #125

Merged
merged 2 commits into from Dec 22, 2022
Merged

chore: update redis default settings #125

merged 2 commits into from Dec 22, 2022

Conversation

cre8ivejp
Copy link
Member

No description provided.

@ono-max
Copy link
Contributor

ono-max commented Dec 22, 2022

Perhaps, we should remove

bucketeer/manifests/bucketeer/values.yaml

Line 1522 in ea58653

serverName: non-persistent-redis
?

ono-max
ono-max previously approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@ono-max ono-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cre8ivejp
Copy link
Member Author

@ono-max
Thanks, I have updated it.

ono-max
ono-max approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@ono-max ono-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cre8ivejp cre8ivejp merged commit 405e495 into main Dec 22, 2022
@cre8ivejp cre8ivejp deleted the chore-redis branch December 22, 2022 14:04
@github-actions github-actions bot mentioned this pull request Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ono-max ono-max ono-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cre8ivejp @ono-max