chore: add time range option in the proto for evaluation count request #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8ivejp
force-pushed
the
chore-evaluation-count
branch
from
6bf7b91
to
fd96fb9
Compare
cre8ivejp
force-pushed
the
chore-evaluation-count
branch
from
fd96fb9
to
949fb15
Compare
ono-max
reviewed
Apr 20, 2023
| @@ -23,6 +23,11 @@ message VariationTimeseries { | |||
| } | |||
|
|
|||
| message Timeseries { | |||
| enum Unit { | |||
There was a problem hiding this comment.
I think that it'll be better to define this filed in GetEvaluationTimeseriesCountResponse. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added time range options to display the time-series count in the Evaluation tab.