feat: add api to get mau summaries #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
masaaania
commented
Oct 17, 2023
•
masaaania
commented
- This PR
- adds an API to summarize MAU. 78f10e0
- adds a cronjob to execute that API. 6094e9d
cre8ivejp
reviewed
Oct 24, 2023
proto/eventcounter/service.proto
Outdated
| @@ -130,6 +131,15 @@ message GetMAUCountResponse { | |||
| int64 user_count = 2; | |||
| } | |||
|
|
|||
| message GetMAUCountsRequest { | |||
| string year_month = 1; | |||
| bool isGroupingBySourceID = 2; | |||
There was a problem hiding this comment.
nit: is_grouping_by_source_id
| environment_namespace as environment_id, | ||
| source_id, | ||
| count(*) as user_count, | ||
| IFNULL(SUM(event_count), 0) as request_count |
There was a problem hiding this comment.
How about adding the evaluation and goal request count to the query?
masaaania
force-pushed
the
mau_sum
branch
2 times, most recently
from
c8e7855
to
7a86be3
Compare
cre8ivejp
reviewed
Oct 26, 2023
| @@ -786,6 +786,106 @@ func TestGetMAUCount(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestSummarizeMAUCounts(t *testing.T) { | |||
There was a problem hiding this comment.
Can you also add the tests for Unauthenticated, PermissionDenied, and Internal while calling the checkAdminRole?
There was a problem hiding this comment.
@cre8ivejp
Thanks, I added it 👍
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.