feat: add organization proto #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8ivejp
reviewed
Nov 22, 2023
proto/environment/service.proto
Outdated
| message UpdateOrganizationRequest { | ||
| string id = 1; | ||
| ChangeDescriptionOrganizationCommand change_description_command = 2; | ||
| RenameOrganizationCommand rename_command = 3; |
There was a problem hiding this comment.
I know a few places use the word rename, but what do you think about using change instead to fit the ChangeDescriptionOrganizationCommand for this service?
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package api |
There was a problem hiding this comment.
Just confirming. The ConvertTrialProject API is not implemented. Are you going to implement it later?
proto/environment/command.proto
Outdated
| string description = 3; // optional | ||
| } | ||
|
|
||
| message CreateTrialOrganizationCommand { |
There was a problem hiding this comment.
What do you think about adding a flag in the CreateOrganizationCommand to create a trial project to reduce the APIs?
|
I updated and fixed the PR. Please take a look when you have time. |
cre8ivejp
reviewed
Nov 22, 2023
proto/environment/command.proto
Outdated
| string name = 1; | ||
| string url_code = 2; | ||
| string description = 3; // optional | ||
| string is_trial = 4; |
There was a problem hiding this comment.
@cre8ivejp
Thank you, nice catch!! 🙏 🙏
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR