feat(ui): flag trigger #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimalgrg519
force-pushed
the
trigger
branch
4 times, most recently
from
ff642c6
to
b2ea552
Compare
cre8ivejp
reviewed
Jan 19, 2024
| "trigger.enableTrigger": "Enable Trigger", | ||
| "trigger.lastTriggered": "Last Triggered", | ||
| "trigger.resetTriggerDialogBtnLabel": "Reset", | ||
| "trigger.resetTriggerDialogMessage": "The current URL will become invalid. Ensure that you copy and save the new URL.", |
There was a problem hiding this comment.
Suggested change
| "trigger.resetTriggerDialogMessage": "The current URL will become invalid. Ensure that you copy and save the new URL.", | |
| "trigger.resetTriggerDialogMessage": "The current URL will become invalid. Ensure that you copy and store the new URL.", |
| "trigger.triggerType": "Type", | ||
| "trigger.triggerURL": "Trigger URL", | ||
| "trigger.triggerUrlDescription": "Once you leave this page, the URL will be hidden.", | ||
| "trigger.triggerUrlTitle": "Copy and save this URL.", |
There was a problem hiding this comment.
Suggested change
| "trigger.triggerUrlTitle": "Copy and save this URL.", | |
| "trigger.triggerUrlTitle": "Copy and store this URL.", |
| }), | ||
| triggerUrlTitle: defineMessage({ | ||
| id: 'trigger.triggerUrlTitle', | ||
| defaultMessage: 'Copy and save this URL.', |
There was a problem hiding this comment.
Suggested change
| defaultMessage: 'Copy and save this URL.', | |
| defaultMessage: 'Copy and store this URL.', |
| resetTriggerDialogMessage: defineMessage({ | ||
| id: 'trigger.resetTriggerDialogMessage', | ||
| defaultMessage: | ||
| 'The current URL will become invalid. Ensure that you copy and save the new URL.', |
There was a problem hiding this comment.
Suggested change
| 'The current URL will become invalid. Ensure that you copy and save the new URL.', | |
| 'The current URL will become invalid. Ensure that you copy and store the new URL.', |
| description: defineMessage({ | ||
| id: 'trigger.description', | ||
| defaultMessage: | ||
| 'Use triggers to turn a flag on or off remotely. See the {link}', |
There was a problem hiding this comment.
Please update the documentation link.
https://docs.bucketeer.io/feature-flags/creating-feature-flags/triggers
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
|
/cla sign |
2 similar comments
|
/cla sign |
|
/cla sign |
|
@bimalgrg519 sorry can you run |
|
/cla sign |
|
Thanks 😄 |
|
Thank you @kentakozuka |
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314