build: change Swiftlint not running when Carthage builds #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakcy
force-pushed
the
fix-carthage-build
branch
from
8b384ac
to
0ec653c
Compare
kakcy
commented
Nov 22, 2023
There was a problem hiding this comment.
Hi @cre8ivejp,
I confirmed that Bucketeer in the Main branch is successfully available via CocoaPods and Swift Package Manager.
Please check this PR while you are free.
| @@ -1075,7 +1075,7 @@ | |||
| ); | |||
| runOnlyForDeploymentPostprocessing = 0; | |||
| shellPath = /bin/sh; | |||
| shellScript = "#Run this script if not in a CI environment.\nif [ -n $CI ] && [ $CI = \"true\" ]; then\n echo \"Run this script if not in a CI environment.\"\n exit 0\nfi\n\n#Workaround: Add Homebrew Path for M1 Mac.\nif [ $(uname -m) = \"arm64\" ]; then\n export PATH=\"/opt/homebrew/bin:/opt/homebrew/sbin:${PATH+:$PATH}\";\nfi\n\nif which mint >/dev/null; then\n make run-lint\nelse\n echo \"Warning: Mint is not installed. Please run make install-mint.\"\nfi\n"; | |||
| shellScript = "#Run this script if not in a CI environment or Carthage build.\nif [ -n $CI ] && [ \"$CI\" = \"true\" ]; then\n echo \"Run this script if not in a CI environment.\"\n exit 0\nelif [ -n \"$CARTHAGE\" ]; then\n echo \"Run this script if not in Carthage build.\"\n exit 0\nfi\n\n#Workaround: Add Homebrew Path for M1 Mac.\nif [ $(uname -m) = \"arm64\" ]; then\n export PATH=\"/opt/homebrew/bin:/opt/homebrew/sbin:${PATH+:$PATH}\";\nfi\n\nif which mint >/dev/null; then\n make run-lint\nelse\n echo \"Warning: Mint is not installed. Please run make install-mint.\"\nfi\n"; | |||
There was a problem hiding this comment.
Since "CARTHAGE=YES" is set as a parameter when building Carthage, I have modified it so that it is used to judge the execution of Swiftlint.
Run Script(linter)
#Run this script if not in a CI environment or Carthage build.
if [ -n $CI ] && [ "$CI" = "true" ]; then
echo "Run this script if not in a CI environment."
exit 0
elif [ -n "$CARTHAGE" ]; then
echo "Run this script if not in Carthage build."
exit 0
fi
...
There was a problem hiding this comment.
thanks @kakcy
I tried your solution and it works 👍🏻.
this changes are nice to have
duyhungtnn
approved these changes
Nov 29, 2023
| @@ -1075,7 +1075,7 @@ | |||
| ); | |||
| runOnlyForDeploymentPostprocessing = 0; | |||
| shellPath = /bin/sh; | |||
| shellScript = "#Run this script if not in a CI environment.\nif [ -n $CI ] && [ $CI = \"true\" ]; then\n echo \"Run this script if not in a CI environment.\"\n exit 0\nfi\n\n#Workaround: Add Homebrew Path for M1 Mac.\nif [ $(uname -m) = \"arm64\" ]; then\n export PATH=\"/opt/homebrew/bin:/opt/homebrew/sbin:${PATH+:$PATH}\";\nfi\n\nif which mint >/dev/null; then\n make run-lint\nelse\n echo \"Warning: Mint is not installed. Please run make install-mint.\"\nfi\n"; | |||
| shellScript = "#Run this script if not in a CI environment or Carthage build.\nif [ -n $CI ] && [ \"$CI\" = \"true\" ]; then\n echo \"Run this script if not in a CI environment.\"\n exit 0\nelif [ -n \"$CARTHAGE\" ]; then\n echo \"Run this script if not in Carthage build.\"\n exit 0\nfi\n\n#Workaround: Add Homebrew Path for M1 Mac.\nif [ $(uname -m) = \"arm64\" ]; then\n export PATH=\"/opt/homebrew/bin:/opt/homebrew/sbin:${PATH+:$PATH}\";\nfi\n\nif which mint >/dev/null; then\n make run-lint\nelse\n echo \"Warning: Mint is not installed. Please run make install-mint.\"\nfi\n"; | |||
There was a problem hiding this comment.
thanks @kakcy
I tried your solution and it works 👍🏻.
this changes are nice to have
| @@ -1075,7 +1075,7 @@ | |||
| ); | |||
| runOnlyForDeploymentPostprocessing = 0; | |||
| shellPath = /bin/sh; | |||
| shellScript = "#Run this script if not in a CI environment.\nif [ -n $CI ] && [ $CI = \"true\" ]; then\n echo \"Run this script if not in a CI environment.\"\n exit 0\nfi\n\n#Workaround: Add Homebrew Path for M1 Mac.\nif [ $(uname -m) = \"arm64\" ]; then\n export PATH=\"/opt/homebrew/bin:/opt/homebrew/sbin:${PATH+:$PATH}\";\nfi\n\nif which mint >/dev/null; then\n make run-lint\nelse\n echo \"Warning: Mint is not installed. Please run make install-mint.\"\nfi\n"; | |||
| shellScript = "#Run this script if not in a CI environment or Carthage build.\nif [ -n $CI ] && [ \"$CI\" = \"true\" ]; then\n echo \"Run this script if not in a CI environment.\"\n exit 0\nelif [ -n \"$CARTHAGE\" ]; then\n echo \"Run this script if not in Carthage build.\"\n exit 0\nfi\n\n#Workaround: Add Homebrew Path for M1 Mac.\nif [ $(uname -m) = \"arm64\" ]; then\n export PATH=\"/opt/homebrew/bin:/opt/homebrew/sbin:${PATH+:$PATH}\";\nfi\n\nif which mint >/dev/null; then\n make run-lint\nelse\n echo \"Warning: Mint is not installed. Please run make install-mint.\"\nfi\n"; | |||
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of changing Swiftlint to run at build time, an error occurs when building with Carthage on the main branch.
The cause is that Swiftlint is executed when building with Carthage.
Changes