Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved drop-down filters for search #34

Open
khemarato opened this issue Oct 11, 2021 · 4 comments
Open

Improved drop-down filters for search #34

khemarato opened this issue Oct 11, 2021 · 4 comments
Labels
enhancement New feature or request Jekyll requires knowledge of Jekyll and the Liquid templating system js requires knowledge of JavaScript

Comments

@khemarato
Copy link
Collaborator

khemarato commented Oct 11, 2021

Right now, search supports type filters via a dropdown and other filters via text (e.g. "+is:music"). It would be nice to add:

  1. Subcats ("is:poetry", etc) (can maybe be added to the existing dropdown?)
  2. Authors (maybe a typeahead dropdown pulling from the _authors collection? Handling hyphens in the filter query will be tricky)
  3. Translator (will have to pull this list by looking at the _authors that actually have translated _content. Perhaps can be combined with the author filter above somehow)
  4. Rating (e.g. "status: featured" content only) This data would have to be added to the search index first, and then given a dropdown.
@khemarato khemarato added enhancement New feature or request js requires knowledge of JavaScript Jekyll requires knowledge of Jekyll and the Liquid templating system labels Oct 11, 2021
@khemarato khemarato added the good first issue Good for newcomers label Jul 23, 2022
@ColmBhandal
Copy link
Contributor

@ColmBhandal
Copy link
Contributor

However, looks like the build isn't configured for forks. So I'm not sure how to test my changes. Please advise...

@khemarato
Copy link
Collaborator Author

Oh! Nice 🙂 To build locally, try:

npm ci
bash scripts/install-deps.bash
bundle install
bundle exec jekyll serve -tI

@khemarato
Copy link
Collaborator Author

Thanks for landing the first PR for this, @ColmBhandal! 🥳 I've updated the description with what's been done and what there's left to do.

@khemarato khemarato removed the good first issue Good for newcomers label Mar 14, 2023
@khemarato khemarato changed the title Drop-down filters for search Improved drop-down filters for search Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Jekyll requires knowledge of Jekyll and the Liquid templating system js requires knowledge of JavaScript
Projects
None yet
Development

No branches or pull requests

2 participants