Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All ids - replace with folder list items #9

Closed
ghost opened this issue Apr 24, 2019 · 1 comment
Closed

All ids - replace with folder list items #9

ghost opened this issue Apr 24, 2019 · 1 comment
Projects

Comments

@ghost
Copy link

ghost commented Apr 24, 2019

Currently, we keep a record of all available records in a collection, in an "allids" file. This is just a list of all record ids in that collection (which can be sharded).

Since implementing this, I had to add a datastore.getFolderContents(path) method - which lists all items in a "folder".

We should now get rid of the "allids" mechanism.

Instead, we should be able to recursively call getFolderContents to iterate through all records.

No public api should change. So, all tests should still pass, except ones that refer to the "allids" files (or shard files) directly.

This new method should respect all existing sharding rules.

@mjashanks mjashanks transferred this issue from mjashanks/budibase-core Jul 15, 2019
@mjashanks mjashanks changed the title All ids - replace with folder list items Core - All ids - replace with folder list items Jul 15, 2019
@mjashanks mjashanks added the core label Nov 3, 2019
@mjashanks mjashanks changed the title Core - All ids - replace with folder list items All ids - replace with folder list items Nov 3, 2019
@mjashanks
Copy link
Member

mjashanks commented Dec 22, 2019

done: 8d43808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
V0.1
  
Awaiting triage
Development

No branches or pull requests

2 participants