Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double click event for CheckBox(Button) and Radio(Button) #1290

Merged
merged 2 commits into from Mar 20, 2019

Conversation

yxngl
Copy link
Contributor

@yxngl yxngl commented Mar 18, 2019

Fix #940 for these label wrapped input. Clicking label will also trigger event on input. related to #711

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #1290 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1290   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files          41       41           
  Lines        1340     1340           
  Branches      416      416           
=======================================
  Hits          615      615           
  Misses        705      705           
  Partials       20       20
Impacted Files Coverage Δ
src/components/checkbox/CheckboxButton.vue 87.5% <ø> (ø) ⬆️
src/components/radio/RadioButton.vue 40% <ø> (ø) ⬆️
src/components/radio/Radio.vue 40% <ø> (ø) ⬆️
src/components/checkbox/Checkbox.vue 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad07cc...aa9ae97. Read the comment docs.

@jtommy
Copy link
Member

jtommy commented Mar 20, 2019

Thanks

@jtommy jtommy merged commit 390ed16 into buefy:dev Mar 20, 2019
@yxngl
Copy link
Contributor Author

yxngl commented Mar 21, 2019

This together with the PR on Switch give only one click event, but the event target could be form different elements which depends on the interaction and usually not the input element, such as span.control-label or span.check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants