Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Property for DialogConfig in buefy/types/components.d.ts #1390

Closed
service-paradis opened this issue May 9, 2019 · 1 comment
Closed
Assignees
Labels

Comments

@service-paradis
Copy link
Collaborator

Overview of the problem

Buefy version: 0.7.5
Vuejs version: 2.6.10

Description

The property focusOn is missing for DialogConfig in buefy/types/components.d.ts. I have lint errors when I'm trying to use this property.

Object literal may only specify known properties, and 'focusOn' does not exist in type 'DialogConfig'.

Steps to reproduce

  1. Use Vue and Typescript
  2. Use $dialog plugin to create a dialog
  3. Set the property focusOn to focus on cancel
  4. Run tslint
    ex.
this.$dialog.confirm({
        title: 'Confirmation',
        message: `This will delete the universe. Do you really want to do this?`,
        cancelText: 'Nope, sorry',
        confirmText: 'Sure!',
        type: 'is-danger',
        hasIcon: true,
        focusOn: 'cancel',
        onConfirm: () => this.deleteUniverse(),
    });

Expected behavior

Linter should be OK with this.

Actual behavior

Linter is displaying an error:

Argument of type '{ title: string; message: string; cancelText: string; confirmText: string; type: string; hasIcon: true; focusOn: string; onConfirm: () => void; }' is not assignable to parameter of type 'DialogConfig'.
  Object literal may only specify known properties, and 'focusOn' does not exist in type 'DialogConfig'.
@jtommy jtommy self-assigned this May 9, 2019
@jtommy jtommy added the bug label May 9, 2019
@jtommy jtommy closed this as completed in c8075d5 May 15, 2019
@onurusluca
Copy link

Still a problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants