Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepicker with min-time and increment-minutes allows hours with no available minutes to be selected #1686

Closed
philnee opened this issue Aug 22, 2019 · 0 comments · Fixed by #1687

Comments

@philnee
Copy link
Contributor

philnee commented Aug 22, 2019

Overview of the problem

Buefy version: 0.8.2
Vuejs version: 2.6.10
OS/Browser Chrome version 76.0.3809.100

Description

If a timepicker with increment-minutes and a min-time is set, can lead to being able to select an hour even through there are no available minutes to be selected for that hour

Steps to reproduce

CodePen https://codepen.io/philnee/pen/qBWqGGJ

  1. Create a timepicker with increment-minutes set to 10 and min-time set to 10:55
  2. Select the hour 10 from the timepicker
  3. All minutes values are disabled

Expected behavior

I would have expected in this scenario that the hour 10 is disabled and the first hour available was 11 as the earliest valid time would be 11:00

Actual behavior

The user can still select 10, however then cannot complete the time as no valid minutes options are available.

I will try and submit a PR later on to fix the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant