Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons with Font Awesome icons print an error since 0.8.3 #1786

Closed
solher opened this issue Sep 22, 2019 · 1 comment · Fixed by #1788
Closed

Buttons with Font Awesome icons print an error since 0.8.3 #1786

solher opened this issue Sep 22, 2019 · 1 comment · Fixed by #1788

Comments

@solher
Copy link

solher commented Sep 22, 2019

Overview of the problem

Buefy version: [0.8.4] and [0.8.3], works fine with [0.8.2]
Vuejs version: [2.6.6]

Description

I'm getting an error [Vue warn]: Invalid prop: custom validator check failed for prop "size". in the console when using a b-button with a Font Awesome icon.

Steps to reproduce

Font Awesome dependencies:

"@fortawesome/fontawesome-svg-core": "^1.2.24",
"@fortawesome/free-brands-svg-icons": "^5.11.1",
"@fortawesome/free-solid-svg-icons": "^5.11.1",
"@fortawesome/vue-fontawesome": "^0.1.7",

Main.js:

import { library } from '@fortawesome/fontawesome-svg-core'
import { faTwitter } from '@fortawesome/free-brands-svg-icons'
import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome'

// Font Awesome
library.add(faTwitter)
Vue.component("font-awesome-icon", FontAwesomeIcon)

// Buefy
Vue.use(Buefy, {
  defaultIconComponent: "font-awesome-icon",
  defaultIconPack: "fas",
})

Template:

<b-button icon-left="twitter" icon-pack="fab" />
@jtommy
Copy link
Member

jtommy commented Sep 22, 2019

It's only a warning but we working on it to remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants