New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vuejs required version to 2.4+ (docs & readme) #242

Merged

rafaberaldo merged 1 commit into buefy:dev from iwan-wijaya:dev

Aug 14, 2017

Contributor

iwan-wijaya commented Aug 11, 2017

$attrs & inhseritAttrs requires vue 2.4


          Change vuejs required version to 2.4+

6d942ea

Member

rafaberaldo commented Aug 11, 2017

But when you use the built js is it still required?

Contributor Author

iwan-wijaya commented Aug 12, 2017

Yes it is, I was using vue 2.3.3 for my project and did an upgrade to Buefy 0.5. input props like placeholder doesn't work anymore because of this:
https://github.com/rafaelpimpa/buefy/blob/dev/src/components/input/Input.vue#L16
https://github.com/rafaelpimpa/buefy/blob/dev/src/components/input/Input.vue#L27

In vue 2.3 placeholder will be applied to the wrong element (root element: div.control)

Member

rafaberaldo commented Aug 14, 2017

Alright, thanks for this!

rafaberaldo merged commit 154a522 into buefy:dev

iwan-wijaya mentioned this pull request

Missing placeholders #270

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment