Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right side of inset shadow not visible on unfocused compact b-numberinput #2791

Closed
askmrsinh opened this issue Aug 21, 2020 · 2 comments · Fixed by #2792 or #2797
Closed

Right side of inset shadow not visible on unfocused compact b-numberinput #2791

askmrsinh opened this issue Aug 21, 2020 · 2 comments · Fixed by #2792 or #2797

Comments

@askmrsinh
Copy link
Contributor

askmrsinh commented Aug 21, 2020

Overview of the problem

Buefy version: 0.9.1
Vuejs version: 2.6.11
OS/Browser: Chromium 84.0.4147.125:

Description

This might be nitpicking but on b-numberinput the right side of the inset shadow is not visible. It's easier to see this defect when using a is-light variant. This issue might also affect other input fields but I haven't checked that yet.

        <b-field label="Compact">
            <b-numberinput controls-position="compact" type="is-info is-light"></b-numberinput>
        </b-field>

OR

        <b-field label="Compact">
            <b-numberinput controls-position="compact" type="is-warning"></b-numberinput>
        </b-field>

image

Using a screen magnifier:
Screenshot from 2020-08-21 01-30-54

@askmrsinh
Copy link
Contributor Author

Checked with older version of Buefy (0.8.20), same behavior.

@askmrsinh
Copy link
Contributor Author

askmrsinh commented Aug 21, 2020

This compiled CSS block seems to be the reason for the issue:

.field.has-addons .control:not(:last-child) {
  margin-right: -1px;
}

Corresponding upstream Bulma SASS.
I believe the above effect is intentional when using addons. However, it just seems weird in this particular case (number input).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant