Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tab in autoselect #354

Merged
merged 2 commits into from Oct 5, 2017
Merged

Conversation

tmepple
Copy link
Contributor

@tmepple tmepple commented Oct 5, 2017

Previously, pressing tab on an autocomplete field would move to the next tabbable element on the page but leave the dropdown open. This PR closes the dropdown while permitting native tab handling to move to the next element.

Additionally, if there is a hovered option it will select it (the same as pressing enter) and move to the next element. This provides for even faster data entry especially when used in conjunction with the keep-first option.

@jtommy
Copy link
Member

jtommy commented Oct 5, 2017

@tmepple It's good! Thanks!

@jtommy jtommy merged commit e9592ce into buefy:dev Oct 5, 2017
@tmepple
Copy link
Contributor Author

tmepple commented Oct 6, 2017

Thanks for the extremely fast review @jtommy!

@tmepple tmepple deleted the handle-tab-in-autoselect branch October 6, 2017 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants