Make bDropdown work server side #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, it's a great library, thanks!!!!!! We use it in our Project. Small improvement: Window doesn't exists server side so we check if it exists before running code that depends on it. We need this for nuxt.js support.
rafaberaldo
approved these changes
Apr 24, 2017
|
Thank you, probably have to make the same with Dialog. I believe it won't work fully with SSR because the click-outside functionality won't work. |
|
Hey @rafaelpimpa! Thanks for merging this! The click-outside functionality might not be relevant when doing SSR. All it has to do on the backend is to render the component’s HTML and data. Once it’s on the client side, Vue should pick it up and set up the listeners as it would normally. |
|
That's great! Didn't know it was that smart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, it's a great library, thanks!!!!!! We use it in our Project. Small improvement:
Window doesn't exists server side so we check if it exists before running code that depends on it. We need this for nuxt.js support.