Fix check to display Autocomplete #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display Autocomplete list if footer slot is registered
✅ Deploy Preview for buefy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@GMartigny I tested the behavior with the following code: <template>
<div class="container is-max-desktop">
<b-field label="Only footer">
<b-autocomplete :data="[]">
<template #footer>
<a><span>Add new...</span></a>
</template>
</b-autocomplete>
</b-field>
</div>
</template>Without your PR: no dropdown showed up With your PR: the dropdown with "Add new..." footer showed up Thanks for your PR! Please attach any reproduction code next time. |
kikuomax
pushed a commit
that referenced
this pull request
Feb 9, 2024
- Fixes the issue that no dropdown showed up if the data array was empty and only the footer slot was registered. Display Autocomplete list if footer slot is registered
64 tasks
kikuomax
pushed a commit
to kikuomax/buefy
that referenced
this pull request
Feb 11, 2024
- Fixes the issue that no dropdown showed up if the data array was empty and only the footer slot was registered. Display Autocomplete list if footer slot is registered
kikuomax
pushed a commit
to ntohq/buefy-next
that referenced
this pull request
Feb 12, 2024
- Fixes the issue that no dropdown showed up if the data array was empty and only the footer slot was registered. Display Autocomplete list if footer slot is registered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display Autocomplete list if footer slot is registered
Proposed Changes