Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRD schema type for x-kubernetes-embedded-resource should be object #156

Closed
alexmg opened this issue Feb 22, 2021 · 2 comments · Fixed by #157
Closed

CRD schema type for x-kubernetes-embedded-resource should be object #156

alexmg opened this issue Feb 22, 2021 · 2 comments · Fixed by #157
Labels
released on @master released

Comments

@alexmg
Copy link
Contributor

alexmg commented Feb 22, 2021

Properties marked as x-kubernetes-embedded-resource must have a schema type of object.

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/validation.go#L113

The CRD generator is not including the type property with a value of object resulting in failures when submitting CRDs with embedded resources.
@alexmg alexmg mentioned this issue Feb 22, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @master released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: CRD schema type for x-kubernetes-embedded-resource should be object alexmg/dotnet-operator-sdk
1 participant
@alexmg