Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #274: Add selector to generated deployment #275

Merged
merged 3 commits into from Sep 8, 2021

Conversation

tillig
Copy link
Contributor

@tillig tillig commented Sep 3, 2021

Resolves #274 by adding the same labels to .spec.selector.matchLabels as are in .spec.template.metadata.labels.

As part of this I also added an .editorconfig (same one we use for Autofac, but it has some reasonable defaults and matches the current editor style/settings from what I can tell) to ensure contributions will match the repo indent styles, etc. I can nuke that if it's not interesting.

@buehler
Copy link
Owner

buehler commented Sep 8, 2021

Regarding the .editorconfig did you consider the .DotSettings file? It is definitely a good addition, if it supports people in contributing to this repo.

@tillig
Copy link
Contributor Author

tillig commented Sep 8, 2021

I didn't add .DotSettings because it assumes Visual Studio + ReSharper. I'm on a Mac using Visual Studio Code - no ReSharper, so it wouldn't do anything for me and I couldn't create it anyway. When I'm on a Windows box (rarely, nowadays) I'm a CodeRush guy, not ReSharper, so... still no help. But .editorconfig works with pretty much everything - VS, VS Code, GitHub web editor, Rider, ReSharper, the whole bit. Most times you don't even need an extension, and if you do, it's free.

@tillig
Copy link
Contributor Author

tillig commented Sep 8, 2021

If it turns out you don't want to take the YAML changes, I can update the PR to remove that and just leave the .editorconfig if that's interesting.

@buehler
Copy link
Owner

buehler commented Sep 8, 2021

As you wrote, I guess this are pretty much the same settings as I've put into the DotSettings file. So I'm happy to have the editorconfig if it helps other people to contribute.

and for the yaml changes: fine by me ;-)

@buehler buehler merged commit 59ecef8 into buehler:master Sep 8, 2021
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

🎉 This PR is included in version 5.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated Deployment missing selector
2 participants