Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make CompareNETObjects' ComparisonConfig configurable #395

Merged
merged 2 commits into from Feb 22, 2022
Merged

feat: make CompareNETObjects' ComparisonConfig configurable #395

merged 2 commits into from Feb 22, 2022

Conversation

erin-allison
Copy link
Contributor

Fixes #364

@erin-allison
Expose ComparisonConfig as an option in OperatorSettings
d9267e9 
Fixes buehler#364

Signed-off-by: Erin Allison <erin@eallison.us>
@erin-allison
Fix tests
34a4b29 
Signed-off-by: Erin Allison <erin@eallison.us>
@erin-allison erin-allison changed the title Expose ComparisonConfig as an option in OperatorSettings feat: make CompareNETObjects' ComparisonConfig configurable Feb 21, 2022
@erin-allison
Copy link
Contributor Author

Ignore the branch name on my fork; I was originally going to just register it in DI but decided that could conflict (in theory) with other libraries, and decided to simply drop it onto OperatorSettings instead.

@buehler buehler merged commit a39f17e into buehler:master Feb 22, 2022
@buehler
Copy link
Owner

buehler commented Feb 22, 2022

Hey @erin-allison,
big thank you for the contribution.

I just made an error: commits that contain a single quote will break the release notes generation for nuget.org.
I guess I'm going to remove the release notes from nuget since nobody ever read them anyway ;-)

@erin-allison
Copy link
Contributor Author

Yeah, I'll be honest; I didn't know release notes were posted on NuGet.

If there are other similar things you think of that I should be careful of in the future, just let me know and I'll do my best.

@buehler
Copy link
Owner

buehler commented Feb 23, 2022

No worries ;-)
Since it's not read, I can just remove it.

There are no other things that are "shakey".

buehler pushed a commit that referenced this pull request Apr 28, 2022
@erin-allison @buehler
feat: make CompareNETObjects ComparisonConfig configurable (#395)
afdd3b9 
* Expose ComparisonConfig as an option in OperatorSettings

Fixes #364

Signed-off-by: Erin Allison <erin@eallison.us>

* Fix tests

Signed-off-by: Erin Allison <erin@eallison.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide ability to alter ComparisonConfig in ResourceCache
2 participants
@erin-allison @buehler