Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse out V1Status for code 422 on Reconcile loop of ManagedController #552

Merged
merged 3 commits into from Apr 14, 2023

Conversation

ewassef
Copy link
Contributor

@ewassef ewassef commented Apr 12, 2023

Give a little better message for errors returned by k8s (at least for code 422).

K8S api will return a V1Status when the API rejects a call. This can be output to the users in the log

Give a little better message for errors returned by k8s (at least for code 422)
@ewassef
Copy link
Contributor Author

ewassef commented Apr 13, 2023

@buehler or @tomasfabian :
Just a simple usability addition that will give the users much more context from a hidden error. The current error message will only mention that the change was a 422 vs giving meaningful responses from the api

@buehler
Copy link
Owner

buehler commented Apr 14, 2023

Thank you for the contribution :-) What do you think about my input for the log message?

@ewassef
Copy link
Contributor Author

ewassef commented Apr 14, 2023

@buehler added a response ... lmk your thoughts and if you still want the change, I will do it

@buehler
Copy link
Owner

buehler commented Apr 14, 2023

Totally makes sense :-)

@buehler buehler merged commit 17147c4 into buehler:master Apr 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants