Skip to content
This repository has been archived by the owner on Oct 10, 2018. It is now read-only.

Feature: Merge imports from the same package #392

Merged
merged 3 commits into from Feb 6, 2018

Conversation

shobhitg
Copy link
Contributor

@shobhitg shobhitg commented Feb 4, 2018

Merge imports from the same package during import organization

  • Closes #348

Description

Merge imports from the same package during import organization

Shobhit Gupta and others added 3 commits February 3, 2018 16:31
@shobhitg
Copy link
Contributor Author

shobhitg commented Feb 5, 2018

I have no clue why travis-ci is unhappy.

@shobhitg
Copy link
Contributor Author

shobhitg commented Feb 6, 2018

@buehler
It seems like src/import-organizer/import-manager.ts has 2 space indents.

But the project's workspace file had tabSize set to 4.

But yet in another file I am seeing 4 space indents.

Is tabSize supposed to be 2 or 4 ?

@buehler
Copy link
Owner

buehler commented Feb 6, 2018

Actually, I switched to tabSize 2. (the .editorconfig should help you with that)

if (actImport.defaultAlias) {
(<NamedImport>libraryAlreadyImported).defaultAlias = actImport.defaultAlias;
}
(<NamedImport>libraryAlreadyImported).specifiers = [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever :-)

@buehler buehler merged commit abc45f1 into buehler:develop Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants