New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Settings & more #112
Conversation
I didn't notice that the build has failed. It's because of an include in |
Thanks for this great PR. ❤️ I will check and validate your changes, ideas in the next view days. So that you have the chance to send a commit for the error check to fix them and the PR is more valid. |
@dugajean again and again - thanks a lot, great PR, nice improvements and I like them and I will merge it fastly. But I will wait for an commit to fix the travis build. |
@bueltge Thanks a lot! I will be fixing that and push it very soon. I'm glad it's proper. |
@dugajean We have also an xml config file for PhpStorm for our php codex; maybe you need them? I will upload to the repository branch so that PhpStorm will use them. Makes easier to format via PhpStorm. |
Added via e8bf9dd |
@bueltge Yes, that would be useful! Thank you! So for the builds, everything should be fine now normally as the tests are passing and I copied the |
That's a great step forward for the project. Maybe we find more time to go the next steps to leave the old plugin, the old code and get solid plugin with code there we will be maintain. Thanks again! |
@bueltge For the error, I can't seem to be able to reproduce it. Maybe it's because we don't have the same environments? I have PHP 7.2.9 and WordPress 4.9.8. I have used a missing function in I'll fix the tab design too. After I fix everything, I'll send another Pull Request. |
After careful inspection I noticed that this error shows up when XDebug is on (it was off in my case). I'm going to look into a fix and push it. Tabs have already been fixed. Pull Request pending... So the issue happens because of the code coverage which happens when XDebug is running. I attempted mocking This problem can be "fixed" by adding |
I think we should not test via UnitTests the templates, so that we can exclude them. |
What's Included in this Pull Request
SettingsRepository
(partial implementation of WP_Cache inclusion)SettingsRepository
Tab
feature refactoringPlease note that this Pull Request is larger than it should be as it includes more than a specific feature. I deemed it as necessary to restructure the plugin's layout into something more intuitive and friendly. If something's out of order, feel free to let me know and I'll fix it.
Things not included in this Pull Request
Tab
have its own key in themw_adminimize
option or should there be only one large form including all settings which are split in tabs?)