/
.golangci.yml
244 lines (244 loc) · 8.22 KB
/
.golangci.yml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
linters-settings:
errcheck:
check-type-assertions: true
forbidigo:
forbid:
# Use private/pkg/thread.Parallelize
- '^errgroup\.'
# Use private/pkg/command.Runner
- '^exec\.Cmd$'
- '^exec\.Command$'
- '^exec\.CommandContext$'
# os.Rename does not work across filesystem boundaries
# See https://github.com/bufbuild/buf/issues/639
- '^os\.Rename$'
# Ban debug statements
- '^fmt\.Print'
- '^log\.'
- '^print$'
- '^println$'
govet:
enable:
- nilness
importas:
alias:
- pkg: github.com/bufbuild/buf/private/gen/proto/go/buf/alpha/image/v1
alias: imagev1
- pkg: github.com/bufbuild/buf/private/gen/proto/go/buf/alpha/module/v1
alias: modulev1
- pkg: github.com/bufbuild/buf/private/gen/proto/go/buf/alpha/registry/v1alpha1
alias: registryv1alpha1
nolintlint:
allow-unused: false
allow-no-explanation: []
require-explanation: true
require-specific: true
linters:
enable:
- asciicheck
- bidichk
- bodyclose
- containedctx
# - contextcheck
- decorder
# - depguard
- dogsled
- errcheck
- execinquery
- exportloopref
- forbidigo
- forcetypeassert
- gci
- gochecknoinits
- gofmt
- goheader
# - goimports
- gomodguard
- goprintffuncname
- gosec
- gosimple
- govet
- grouper
- importas
- ineffassign
- logrlint
- makezero
- mirror
- misspell
- nakedret
- nilerr
- nolintlint
- nosprintfhostport
- paralleltest
- predeclared
- promlinter
- reassign
- rowserrcheck
- staticcheck
- stylecheck
- typecheck
- unconvert
- unused
- wastedassign
- whitespace
disable-all: true
issues:
exclude-dirs-use-default: false
exclude-rules:
- linters:
- forbidigo
# this is one of two files we want to allow exec.Cmd functions in
path: private/pkg/command/runner.go
- linters:
- forbidigo
# this is one of two files we want to allow exec.Cmd functions in
path: private/pkg/command/process.go
- linters:
- forbidigo
# we use os.Rename here to rename files in the same directory
# This is safe (we aren't traversing filesystem boundaries).
path: private/pkg/storage/storageos/bucket.go
text: "os.Rename"
- linters:
- stylecheck
text: "ST1005:"
- linters:
- errcheck
# headers.go has casts with values from contexts that should fail if there
# is no error, but it would be very unidiomatic to return an error from
# the functions that do these casts, and we completely control the
# context values within this file
path: private/pkg/rpc/headers.go
- linters:
- gosec
# G101 checks for hardcoded credentials, and the variables named "*Password*
# trip this off.
path: private/buf/bufcli/bufcli.go
text: "G101:"
- linters:
- gosec
# G204 checks that exec.Command is not called with non-constants.
path: private/pkg/command/runner.go
text: "G204:"
- linters:
- wastedassign
# netrc/internal is a library largely copied in from an external repository with attribution.
# We try to make minimal edits.
path: private/pkg/netrc/internal/internal.go
# we actually want to use this init to create a protovalidate.Validator
- linters:
- gochecknoinits
path: private/bufpkg/bufcas/proto.go
# we actually want to use this init in testing
- linters:
- gochecknoinits
path: private/bufpkg/bufmodule/bufmoduletesting/bufmoduletesting.go
# we actually want to use this init
- linters:
- gochecknoinits
path: private/usage/usage.go
# we actually want to embed a context here
- linters:
- containedctx
path: private/bufpkg/bufmodule/bufmoduleprotoparse/path_resolver.go
# we actually want to embed a context here
- linters:
- containedctx
path: private/pkg/transport/grpc/grpcclient/client_conn_provider.go
# we actually want to use errgroup when starting an HTTP server
- linters:
- forbidigo
path: private/pkg/transport/http/httpserver/httpserver.go
text: "use of `errgroup"
# we want to use errgroup here
- linters:
- forbidigo
path: private/bufpkg/bufplugin/bufplugindocker/docker.go
text: "use of `errgroup"
- linters:
- containedctx
path: private/bufpkg/bufmodule/bufmoduleprotocompile
# We should be able to use net/http/cgi in a unit test, in addition the CVE mentions only versions of go < 1.6.3 are affected.
- linters:
- gosec
path: private/pkg/git/git_test.go
text: "G504:"
- linters:
- stylecheck
path: private/bufpkg/bufapimodule/module_resolver_test.go
text: "ST1003:"
- linters:
- dogsled
# One function call doesn't care about most of the returned destructured values. The
# dogsled linter complains about it. (Value of this linter is unclear...)
path: private/buf/cmd/buf/command/curl/curl.go
- linters:
- containedctx
# Type must implement an interface whose methods do not accept context. But this
# implementation makes RPC calls, which need a context. So we allow creator of the
# type to provide a context at value creation (instead of using context.Background()).
path: private/buf/bufcurl/reflection_resolver.go
# We deprecated all the definitions in plugin.proto but we still implement them.
- linters:
- staticcheck
text: "buf/alpha/registry/v1alpha1/plugin.proto is marked as deprecated"
# We deprecated all the definitions in generate.proto but we still implement them.
- linters:
- staticcheck
text: "buf/alpha/registry/v1alpha1/generate.proto is marked as deprecated"
# We need to handle this field in descriptor.proto.
- linters:
- staticcheck
text: "GetDeprecatedLegacyJsonFieldConflicts is deprecated"
- linters:
- staticcheck
text: "GetIgnoreEmpty is deprecated"
path: private/bufpkg/bufcheck/buflint/internal/buflintvalidate/field.go
- linters:
- staticcheck
text: "GetSkipped is deprecated"
path: private/bufpkg/bufcheck/buflint/internal/buflintvalidate/field.go
# We verify manually so that we can emit verbose output while doing so.
- linters:
- gosec
text: "G402:"
path: private/buf/bufcurl/tls.go
# We don't need a cryptographically secure RNG for these tests, and a
# deterministic RNG is actually nice for test repeatability.
- linters:
- gosec
text: "G404:"
path: private/bufpkg/bufimage/bufimageutil/.*_test\.go
# This test shouldn't run in parallel as it allocates a lot of memory.
- linters:
- paralleltest
text: "missing the call to method parallel"
path: private/bufpkg/bufimage/bufimagebuild/builder_unix_test.go
# TestWorkspaceArchiveDir, TestWorkspaceWithInvalidArchivePathFail
# and TestWorkspaceWithInvalidArchiveAbsolutePathFail cannot run in parallel
# because they all call createZipFromDir on the same path, writing to the same file.
- linters:
- paralleltest
text: "missing the call to method parallel"
path: private/buf/cmd/buf/workspace_test.go
# Parallelizing TestPlainPostHandlerTLS and TestPlainPostHandlerH2C
# makes this test flaky.
- linters:
- paralleltest
path: private/bufpkg/bufstudioagent/bufstudioagent_test.go
text: "missing the call to method parallel"
# Buf sync branches are not synced (nor tested) in parallel
- linters:
- paralleltest
text: "missing the call to method parallel"
path: private/buf/bufsync/commits_to_sync_test.go
# A git repo is not safe to read concurrently, since it has a single object reader.
- linters:
- paralleltest
text: "missing the call to method parallel"
path: private/pkg/git/repository_test.go
# This greatly simplifies creation of descriptors, and it's safe enough since
# it's just test code.
- linters:
- forcetypeassert
path: private/bufpkg/bufimage/source_retention_options_test\.go